Skip to content

Birmingham | 26-ITP-May | Ogbemi Mene | Sprint 2 | Wireframe onboarding #1305

Open
meneogbemi42-bit wants to merge 4 commits into
CodeYourFuture:mainfrom
meneogbemi42-bit:feature/wireframe
Open

Birmingham | 26-ITP-May | Ogbemi Mene | Sprint 2 | Wireframe onboarding #1305
meneogbemi42-bit wants to merge 4 commits into
CodeYourFuture:mainfrom
meneogbemi42-bit:feature/wireframe

Conversation

@meneogbemi42-bit
Copy link
Copy Markdown

@meneogbemi42-bit meneogbemi42-bit commented May 17, 2026 •
edited
Loading

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

I generated this code myself and its a wireframe of a website defining the purpose of readme file and branch in GIt.

@netlify
Copy link
Copy Markdown

netlify Bot commented May 17, 2026 •
edited
Loading

✅ Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit 18c8b8b
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/6a1299edfd384c000806215a
😎 Deploy Preview https://deploy-preview-1305--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 86 (no change from production)
PWA: -
View the detailed breakdown and full score reports
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions

This comment has been minimized.

Sign in to view
@meneogbemi42-bit meneogbemi42-bit added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 17, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 17, 2026
@meneogbemi42-bit meneogbemi42-bit added 📅 Sprint 2 Assigned during Sprint 2 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Submit:PR This work is submitted by creating a PR against CodeYourFuture's fork of this repo. NotCoursework and removed Submit:PR This work is submitted by creating a PR against CodeYourFuture's fork of this repo. NotCoursework labels May 17, 2026
@github-actions

This comment has been minimized.

Sign in to view
1 similar comment
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 17, 2026
@meneogbemi42-bit meneogbemi42-bit added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 17, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 17, 2026
@meneogbemi42-bit meneogbemi42-bit added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. NotCoursework and removed NotCoursework labels May 17, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 18, 2026
@meneogbemi42-bit meneogbemi42-bit changed the title Birmigham | 26-ITP-May | Ogbemi Mene | Sprint 2 | Wireframe onboarding Birmingham | 26-ITP-May | Ogbemi Mene | Sprint 2 | Wireframe onboarding May 18, 2026
@github-actions

This comment has been minimized.

Sign in to view
4 similar comments
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
2 similar comments
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@meneogbemi42-bit meneogbemi42-bit added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 18, 2026
cjyuan
cjyuan reviewed May 20, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The layout of your page does not yet look like the wireframe.

Please pay close attention to every details in the wireframe image.

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels May 20, 2026
@meneogbemi42-bit meneogbemi42-bit added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels May 23, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 23, 2026
@github-actions

This comment has been minimized.

Sign in to view
@cjyuan
Copy link
Copy Markdown
Contributor

cjyuan commented May 23, 2026

You have a folder name "Module-Onboarding" in your repo on this branch.

You need to remove that folder or else the Validation bot will reject your PR.

@meneogbemi42-bit meneogbemi42-bit added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 24, 2026
cjyuan
cjyuan reviewed May 24, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. According to https://validator.w3.org/, there is an error in your HTML code. Can you fix it?

  2. To meet the requirement "The articles section contains three distinct articles, each with its own unique image, title, summary, and link.", can you use distinct images among the articles?

  3. There are some inconsistent spellings in the text content. Can you address this issue with the help of an AI tool?

  4. The code is not yet consistently formatted. You may want to follow the suggestions in Format Code and Make Logical Commits in VS Code to keep your code consistently formatted.

  5. In terms of the page layout, good progress so far! I'd like you to compare your page carefully against the wireframe and identify any differences in alignment and positioning of elements.

    Once you've done that review, revisit your implementation and make adjustments where needed to bring the layout closer to the wireframe.

    You will likely need to make some changes in style.css to achieve this.

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels May 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjyuan cjyuan cjyuan left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

Reviewed Volunteer to add when completing a review with trainee action still to take. 📅 Sprint 2 Assigned during Sprint 2 of this module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@meneogbemi42-bit @cjyuan